Re: [patch] staging: rtl8723au: incorrect use of ether_addr_copy()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 08, 2014 at 03:59:33PM +0200, Jes Sorensen wrote:
> Dan Carpenter <dan.carpenter@xxxxxxxxxx> writes:
> > The return from myid() isn't aligned correctly for ether_addr_copy().
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> 
> Sorry, this makes no sense, just fix it properly!
> 
> drivers/staging/rtl8723au/include/rtw_eeprom.h:
> 
> struct eeprom_priv {
>         u8              bautoload_fail_flag;
>         u8              bloadfile_fail_flag;
>         u8              bloadmac_fail_flag;
>         /* u8           bempty; */
>         /* u8           sys_config; */
>         u8              mac_addr[6];    /* PermanentAddress */
>         /* u8           config0; */
> 
> Move mac_addr[6] to the top of the struct and be done with it.
> 
> NACK

Oops.  I thought it was something from the hardware.  Actually can you
fix it and give me a reported-by tag?

regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux