Re: [PATCH 1/5] Combine ifs into one where possible to avoid unnecessary indentation level increase

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Oct 03, 2014 at 11:27:04PM +0300, Giedrius Statkevicius wrote:
> From: Giedrius Statkevičius <giedrius.statkevicius@xxxxxxxxx>
> 
> Join together chained if's where possible to lower the indentation level.
> 
> Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@xxxxxxxxx>

Your subject is "odd", in that it doesn't say what part of the kernel it
is for.  Look at the kernel git logs, it should give you an idea of how
to format things properly.

Also, you don't have to have such a long subject:, try to keep it short,
and then be verbose in the changelog body.

Can you fix up all of these 5 and resend?

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel





[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux