On Thu, 2014-10-02 at 17:01 +0000, Hartley Sweeten wrote: > On Thursday, October 02, 2014 7:41 AM, Chen Gang wrote: > > COMEDI_II_PCI20KC needs HAS_IOMEM, so depend on it. The related error ( > > with allmodconfig under um): > > > > CC [M] drivers/staging/comedi/drivers/ii_pci20kc.o > > drivers/staging/comedi/drivers/ii_pci20kc.c: In function ‘ii20k_attach’: > > drivers/staging/comedi/drivers/ii_pci20kc.c:442:2: error: implicit declaration of function ‘ioremap’ [-Werror=implicit-function-declaration] > > dev->mmio = ioremap(membase, II20K_SIZE); > > ^ > > drivers/staging/comedi/drivers/ii_pci20kc.c:442:12: warning: assignment makes pointer from integer without a cast [enabled by default] > > dev->mmio = ioremap(membase, II20K_SIZE); > > ^ > > drivers/staging/comedi/drivers/ii_pci20kc.c: In function ‘ii20k_detach’: > > drivers/staging/comedi/drivers/ii_pci20kc.c:512:3: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration] > > iounmap(dev->mmio); > > ^ > > > > Signed-off-by: Chen Gang <gang.chen.5i5j@xxxxxxxxx> > > --- > > drivers/staging/comedi/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/staging/comedi/Kconfig b/drivers/staging/comedi/Kconfig > > index a8bc2b5..b709736 100644 > > --- a/drivers/staging/comedi/Kconfig > > +++ b/drivers/staging/comedi/Kconfig > > @@ -426,6 +426,7 @@ config COMEDI_AIO_IIRO_16 > > > > config COMEDI_II_PCI20KC > > tristate "Intelligent Instruments PCI-20001C carrier support" > > + depends on HAS_IOMEM > > ---help--- > > Enable support for Intelligent Instruments PCI-20001C carrier > > PCI-20001, PCI-20006 and PCI-20341 > > This seems appropriate. > > Reviewed-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx> > Since "egrep -irn "ioremap" drivers/staging/comedi/drivers | wc -l" shows "39" does it mean that this should be added to all the other drivers as well? Rostislav Lisovy _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
