Re: [PATCH 05/67] staging: unisys: fix spacing in timskmod.h macro

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 30, 2014 at 12:07:49PM -0400, Benjamin Romer wrote:
> Adds in some missing spaces in the max macro in timskmod.h.
> 
> Signed-off-by: Benjamin Romer <benjamin.romer@xxxxxxxxxx>
> ---
>  drivers/staging/unisys/include/timskmod.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/unisys/include/timskmod.h b/drivers/staging/unisys/include/timskmod.h
> index 0f59b3c..9e78311 100644
> --- a/drivers/staging/unisys/include/timskmod.h
> +++ b/drivers/staging/unisys/include/timskmod.h
> @@ -155,7 +155,7 @@
>  	} while (0)
>  
>  #ifndef max
> -#define max(a, b) (((a) > (b)) ? (a):(b))
> +#define max(a, b) (((a) > (b)) ? (a) : (b))
>  #endif

Just delete these in a future patch, this definition is wrong, and you
should use the in-kernel one instead.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux