Hi, Le samedi 27 septembre 2014 à 10:52 +0200, Heinrich Schuchardt a écrit : > sync.h recommends to use get_unused_fd which does not set > O_CLOEXEC while the rest of the android tree uses > get_unused_fd_flags and sets O_CLOEXEC. > > The patch adjust the comment. > I'd like to add this patch to my patchset which try to remove get_unused_fd() in favor of get_unused_fd_flags(): http://lkml.kernel.org/r/cover.1411562410.git.ydroneaud@xxxxxxxxxx But having O_CLOEXEC is welcome but not strictly needed, so I think the patch should be reworked to not require O_CLOEXEC. > Signed-off-by: Heinrich Schuchardt <xypron.glpk@xxxxxx> > --- > drivers/staging/android/sync.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/android/sync.h b/drivers/staging/android/sync.h > index 66b0f43..a21b79f 100644 > --- a/drivers/staging/android/sync.h > +++ b/drivers/staging/android/sync.h > @@ -293,7 +293,8 @@ void sync_fence_put(struct sync_fence *fence); > * @fence: fence to install > * @fd: file descriptor in which to install the fence > * > - * Installs @fence into @fd. @fd's should be acquired through get_unused_fd(). > + * Installs @fence into @fd. @fd's should be acquired through > + * get_unused_fd_flags(O_CLOEXEC). I think it will be better to have something like: get_unused_fd_flags(flags), with flags either provided by userspace or set to O_CLOEXEC. > */ > void sync_fence_install(struct sync_fence *fence, int fd); > Regards. -- Yann Droneaud OPTEYA _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
