Re: [PATCH] Fixed Conditional white space problems

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Sep 28, 2014 at 06:01:01PM -0400, Greg KH wrote:
> On Sun, Sep 28, 2014 at 04:54:26PM -0500, Eric Rost wrote:
> > My first patch, resent to appropriate multiple addresses!
> 
> That's great, but it doesn't belong here in the body of the changelog :)
> 
> > This patch fixes the following checkpatch.pl Warnings:
> > 
> > WARNING: suspect code indent for conditional statements (16, 16)
> > +               for (r = 1; r < 2 * RCNT; r += 2 * SKEIN_UNROLL_512)
> > [...]
> > +               {
> > 
> > WARNING: suspect code indent for conditional statements (16, 16)
> > +               for (r = 1; r <= 2 * RCNT; r += 2 * SKEIN_UNROLL_1024)
> > [...]
> > +               {
> 
> Your subject should give a clue as to what part of the kernel it
> modifies, for this patch, it might look like:
> 	staging: skein: fixed conditional...
> 
> Care to fix that up and resend?

With Greg's comments addressed,

Acked-by: Jason Cooper <jason@xxxxxxxxxxxxxx>

thx,

Jason.
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux