Re: [PATCH 0/9] staging: unisys: checkpatch strict cleanup in include

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 24, 2014 at 07:12:03PM +0300, Dan Carpenter wrote:
> Gar.  I hate to make you redo a lot of work but these need to be broken
> up into "one thing per patch".  That rules is kind of vague so we
> normally tell people to fix one type of checkpatch.pl warning at a time
> as a simple way of explaining it.
> 
> But definitely "fixing every checkpatch.pl warning in a file" is not
> one thing unless there are like 2 lines of change only.

I agree, please fix this up into "one logical change per patch".

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux