[PATCH 2/2] staging: et131x: Simplify for loop in et131x_init_send()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The for loop in this function increments two variables and has an unusual
starting index of 1 (not 0). Make it look more familiar.

Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Signed-off-by: Mark Einon <mark.einon@xxxxxxxxx>
---
 drivers/staging/et131x/et131x.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index d564859..30ee5e3 100644
--- a/drivers/staging/et131x/et131x.c
+++ b/drivers/staging/et131x/et131x.c
@@ -1747,7 +1747,7 @@ static void et131x_disable_txrx(struct net_device *netdev)
 
 static void et131x_init_send(struct et131x_adapter *adapter)
 {
-	u32 ct;
+	int i;
 	struct tx_ring *tx_ring = &adapter->tx_ring;
 	struct tcb *tcb = tx_ring->tcb_ring;
 
@@ -1755,8 +1755,10 @@ static void et131x_init_send(struct et131x_adapter *adapter)
 
 	memset(tcb, 0, sizeof(struct tcb) * NUM_TCB);
 
-	for (ct = 0; ct++ < NUM_TCB; tcb++)
+	for (i = 0; i < NUM_TCB; i++) {
 		tcb->next = tcb + 1;
+		tcb++;
+	}
 
 	tcb--;
 	tx_ring->tcb_qtail = tcb;
-- 
2.1.1

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux