On Wed, Sep 24, 2014 at 01:11:42PM +0300, Dan Carpenter wrote:
> On Mon, Sep 22, 2014 at 08:58:14PM +0100, Mark Einon wrote:
> > static void et131x_rx_dma_memory_free(struct et131x_adapter *adapter)
> > {
> > u8 id;
> > - u32 index;
> > + u32 ii;
>
> Just use "int i;". Making everything a u32 is a bad habbit and the
> second 'i' character doesn't seem to stand for anything.
Hi Dan,
THanks for the review.
I use 'ii' because it's easier to search in the code.
It's a u32 because it's counting over fbr->num_entries, which is also
u32, why would you change it to an int, exactly?
Cheers,
Mark
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
