On Tue, 2014-09-23 at 21:02 +0200, Francois Romieu wrote: > Mark Einon <mark.einon@xxxxxxxxx> : > [...] > > > No need for the #define here, just assigne et131x_pm_ops to .driver.pm > > > directly, its members will be NULL and thus never called. Also, you can > > > make et131x_pm_ops const. > > > > Ok, I can change this. > > > > Btw, this appears to be a fairly standard way of using .driver.pm among > > ethernet drivers, e.g. see 3com/3c59x.c, atheros, marvell... - perhaps > > there is a case for changing all instances of this code? > > How about kernel tinification ? The tiny case where a large number of ethernet drivers are included? _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel