On Thu, 18 Sep 2014, micky wrote: > On 09/18/2014 12:53 PM, Lee Jones wrote: > >On Thu, 18 Sep 2014, micky_ching@xxxxxxxxxxxxxx wrote: > > > >>From: Micky Ching <micky_ching@xxxxxxxxxxxxxx> > >> > >>Fix rts5227&5249 failed send buffer cmd after suspend, > >>PM_CTRL3 should reset before send any buffer cmd after suspend. > >>Otherwise, buffer cmd will failed, this will lead resume fail. > >> > >>Signed-off-by: Micky Ching <micky_ching@xxxxxxxxxxxxxx> > >>--- > >> drivers/mfd/rts5227.c | 19 +++++++++++++++++++ > >> drivers/mfd/rts5249.c | 4 ++++ > >> drivers/mfd/rtsx_pcr.h | 1 + > >> include/linux/mfd/rtsx_pci.h | 12 ++++++++++++ > >> 4 files changed, 36 insertions(+) > >I think you'll find you just broke the build. > > > >What happens when you compile these as modules? > I build as modules with no warning or error, did you find anything wrong? Yes, you don't export the functions. EXPORT_SYMBOL() -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
