Re: [PATCH 3/9] staging: comedi: ni_usb6501: fix response_size

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 15, 2014 at 02:59:33PM +0200, Luca Ellero wrote:
> Fix response_size in ni6501_send_command (READ_PORT command)

This isn't a fix, it's a cleanup.  A fix is something that fixes a bug.
We are sloppy about correcting newbies who are always writing checkpatch
"fixes"...  There is an endless stream of newbies so I gave up
correcting them long ago.

Anyway the changelog is bad because it says it is a bugfix, but it
doesn't give the before size or the after size or tell what the problem
was or the implications of the bug.

Otherwise this is a good cleanup.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux