On Sat, Sep 13, 2014 at 12:23:04PM +0300, Dan Carpenter wrote: > On Thu, Sep 11, 2014 at 10:59:40PM +0100, Mark Einon wrote: > > + if (send_packet(skb, adapter)) > > + goto drop_err; > > + > > + return NETDEV_TX_OK; > > + > > +drop_err: > > + dev_kfree_skb_any(skb); > > + skb = NULL; > > No need to set "skb = NULL;". It's on the stack after all. Hi Dan, Thanks for the review, and you're right. I'll put it in another patch - let me know if that's an issue. Cheers, Mark _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
