On Thu, Sep 11, 2014 at 03:17:52PM +0800, micky_ching@xxxxxxxxxxxxxx wrote:
> + /* reset PM_CTRL3 before send buffer cmd */
> + err = rtsx_pci_write_register(pcr, PM_CTRL3, 0x10, 0x00);
> + if (err < 0)
> + return err;
> +
> + return err;
Just do:
return rtsx_pci_write_register(pcr, PM_CTRL3, 0x10, 0x00);
> +}
> +
> static int rts5227_optimize_phy(struct rtsx_pcr *pcr)
> {
> + int err;
> +
> + err = rts5227_pm_reset(pcr);
> + if (err < 0)
> + return err;
> +
> /* Optimize RX sensitivity */
> return rtsx_pci_write_phy_register(pcr, 0x00, 0xBA42);
> }
> diff --git a/include/linux/mfd/rtsx_pci.h b/include/linux/mfd/rtsx_pci.h
> index 74346d5..037fbc5 100644
> --- a/include/linux/mfd/rtsx_pci.h
> +++ b/include/linux/mfd/rtsx_pci.h
> @@ -967,4 +967,17 @@ static inline u8 *rtsx_pci_get_cmd_data(struct rtsx_pcr *pcr)
> return (u8 *)(pcr->host_cmds_ptr);
> }
>
> +static inline int rtsx_pci_update_cfg_byte(struct rtsx_pcr *pcr, int addr,
> + u8 mask, u8 append)
> +{
> + int err;
> + u8 val;
> +
> + err = pci_read_config_byte(pcr->pci, addr, &val);
> + if (err)
> + return err;
Some of these check for "if (err) " and some check for "if (err < 0) ".
What is the significance of that? I'm a newbie here. Did you mean for
them to be different?
> + err = pci_write_config_byte(pcr->pci, addr, (val & mask) | append);
> + return err;
return pci_write_config_byte(pcr->pci, addr, (val & mask) | append);
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
