On 09/08/2014 04:17 PM, Greg KH wrote:
On Sat, Aug 30, 2014 at 04:35:56PM -0400, wfp5p@xxxxxxxxxxxxxxx wrote:
From: Bill Pemberton <wfp5p@xxxxxxxxxxxxxxx>
The jsm driver (drivers/tty/serial/jsm) already supports the Digi Neo
cards that dgnc (staging) supports. In fact, it appears that jsm was
based on dgnc. The dgnc driver has PCI ids for more cards than jsm,
this patch moves support for all the Neo cards to jsm.
The result of this will be that dgnc will only support the Classic
cards since the jsm driver doesn't support those cards yet.
Bill Pemberton (2):
jsm: add support for additional Neo cards
staging: dgnc: remove Neo card ids from device table
drivers/staging/dgnc/dgnc_driver.c | 13 -------------
drivers/tty/serial/jsm/jsm.h | 10 ++++++++++
drivers/tty/serial/jsm/jsm_driver.c | 38 +++++++++++++++++++++++++++++++++----
3 files changed, 44 insertions(+), 17 deletions(-)
These are now applied, thanks.
Do you think we can delete the dgnc driver now, or are there still some
odd cards out there that it only supports? What would it take to move
that support to the jsm driver instead?
The jsm driver still doesn't support the Classic cards, just the Neo
cards so dgnc would still be needed to support those cards.
I think the right thing would be to put the Classic support into jsm.
I've started looking at that. Dgnc and jsm are obviously from the same
base, so dgnc can be used as guide on what to do. However, I don't have
a Classic card so I wouldn't be able to test any of the Classic support.
--
Bill
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
