On Mon, Sep 08, 2014 at 10:57:08AM -0500, Romer, Benjamin M wrote: > On Fri, 2014-09-05 at 14:52 +0530, Sudip Mukherjee wrote: > > fixed sparse warning : context imbalance in 'pause_device' > > unexpected unlock > > this patch will generate warning from checkpatch for > > lines over 80 character , but since those are user-visible strings > > so it was not modified. > > > > Signed-off-by: Sudip Mukherjee <sudip@xxxxxxxxxxxxxxx> > > --- > > > > hi , can you please review the patch and see if the approach is correct. > > The functiion is still doing the same what it was doing , only the logic > > is changed. if the approach is ok, then i can send a patch to fix the > > other two similar warning in the file. > > Hi Sudip, > > I was able to successfully build and test your patch. The changes look > good to me too, so I think we should take this patch. :) > > Thanks! > -- Ben > Hi Ben, thanks. the same file is having two more similar warnings. if you want i can resend a patch fixing all the three warnings , or i can send two separate patches. I personally will prefer two separate patches , as that will be easier for you to test and review. thanks sudip > Signed-off-by: Benjamin Romer <benjamin.romer@xxxxxxxxxx> > Tested-by: Benjamin Romer <benjamin.romer@xxxxxxxxxx> _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
