Re: [PATCH 3/6] staging: goldfish: document spinlock usage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 03, 2014 at 01:13:19PM +0100, One Thousand Gnomes wrote:
> 
> This tells the reader nothing. It's good to document locking models but
> 
> - you lock data not code (which is a detail a lot of programmers get wrong
> 			  in th design stage too)
> - you need to document what objects are protected by the lock
> 
> 
> So it should tell the reader what the lock must be held to do
> 
> If you look at the audio code it actually protects the status field and
> status register of the "hardware"

Hello,

Thank you for the feedback, I will send a v2.

-- 
Cheers,
Loïc
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel





[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux