On Mon, 2014-09-01 at 23:52 +0800, sunwxg wrote: > Fix the style error checking by checkpatch.pl > ERROR: space required after that ',' [] > diff --git a/drivers/staging/lustre/lustre/lov/lov_pack.c b/drivers/staging/lustre/lustre/lov/lov_pack.c [] > @@ -95,7 +95,7 @@ void lov_dump_lmm_v1(int level, struct lov_mds_md_v1 *lmm) > void lov_dump_lmm_v3(int level, struct lov_mds_md_v3 *lmm) > { > lov_dump_lmm_common(level, lmm); > - CDEBUG(level,"pool_name "LOV_POOLNAMEF"\n", lmm->lmm_pool_name); > + CDEBUG(level, "pool_name "LOV_POOLNAMEF"\n", lmm->lmm_pool_name); I think it better to separate the pre-coalesced bits of the string like: "pool name " LOV_POOLNAMEF "\n", _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel