Re: [PATCH v3 00/11] lib: introduce string_escape_mem and %*pE specifier

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 29, 2014 at 12:06 AM, Andrew Morton
<akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Thu, 28 Aug 2014 23:58:45 +0300 Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote:

[]

>> For now (so far no more comments) it is only couple of trivia fixes
>> (removing useless comments). Would you like to resend whole series or
>> just fixup would be enough?
>
> I fixed up the one Joe commented on.
>
> --- a/lib/vsprintf.c~lib-vsprintf-add-%pe-format-specifier-fix
> +++ a/lib/vsprintf.c
> @@ -1111,12 +1111,11 @@ char *escaped_string(char *buf, char *en
>         int len;
>
>         if (spec.field_width == 0)
> -               /* nothing to print */
> -               return buf;
> +               return buf;                             /* nothing to print */
>
>         if (ZERO_OR_NULL_PTR(addr))
> -               /* NULL pointer */
> -               return string(buf, end, NULL, spec);
> +               return string(buf, end, NULL, spec);    /* NULL pointer */
> +
>
>         do {
>                 switch (fmt[count++]) {

Thanks! I'm fine with this fix.


-- 
With Best Regards,
Andy Shevchenko
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux