Re: Fwd: Re: [PATCH] staging:lustre:lnet: lib-md.c fix checkpath warnings and errors.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/28/2014 10:20 AM, Janet Liu wrote:



-------- Original Message --------
Subject: Re: [PATCH] staging:lustre:lnet: lib-md.c fix checkpath
warnings and errors.
Date: Tue, 26 Aug 2014 18:22:45 -0700
From: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
To: Janet Liu <janetliu526@xxxxxx>
CC: devel@xxxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx

On Mon, Aug 25, 2014 at 01:18:54AM +0800, Janet Liu wrote:
Sliences the following warning and error:

  WARNING: line over 80 characters
  WARNING: space prohibited between function name and open parenthesis
'('
  ERROR: do not use C99 // comments
  ERROR: trailing statements should be on next line

You changed 4 things, in one patch :(

Also, you sent 4 different patches, which one is correct?

Please only do one thing per patch and please resend with the one that
you wish to have reviewed.

thanks,

greg k-h


Hi Greg,

I'm very sorry for having troubled you.

The latest one is correct. It is send by my gmail box.

The first two is sent by this mailbox(janetliu526@xxxxxx) and is rejected by linux-kernel@xxxxxxxxxxxxxxx.

The third is tested by dan.carpenter@xxxxxxxxxx, he told me it broke build. So I fixed and send the fourth.

Those are all codestyle issue.

regards,
janet
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux