On Wednesday, August 27, 2014 11:00 AM, Ian Abbott wrote: > On 26/08/14 00:04, H Hartley Sweeten wrote: >> The comedi core does the sanity checking of the comedi_insn before >> calling the (*insn_write). Remove the unnecessary checks. >> >> Signed-off-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx> >> Cc: Ian Abbott <abbotti@xxxxxxxxx> >> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> >> --- >> drivers/staging/comedi/drivers/me4000.c | 33 ++------------------------------- >> 1 file changed, 2 insertions(+), 31 deletions(-) [snip] > I thought you might have updated this function to handle the insn->n > 1 > case as well. Maybe in a follow-up patch? There are a couple that have the insn->n > 1 issue. For some of them I have not located a datasheet/user manual to verify the proper way to handle multiple writes to the DAC. I will fix those in follow-up patches. Regards, Hartley _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
