On Mon, 2014-08-25 at 08:51 -0500, Greg Donald wrote: > On Mon, Aug 25, 2014 at 8:15 AM, Joe Perches <joe@xxxxxxxxxxx> wrote: > > On Mon, 2014-08-25 at 06:35 -0500, Greg Donald wrote: > >> Fix checkpatch.pl spaces required around that '?' errors > > > > It'd be better to convert all parts of the > > ternary at the same time. > > Wouldn't "at the same time" be in direct conflict with the "only do > one thing per patch" rule? No because these are both whitespace changes around a ternary. As far as I'm concerned, a single patch to do all horizontal whitespace corrections at the same time is just fine. Just make sure to check your changes don't modify anything with git diff -w and scripts/objdiff. > > A subsequent change might be to remove the unnecessary > > parentheses like: > > > > force_exec ? "force to" : "", dec_bt_pwr ? "ON" : "OFF"); > > I understand. It's very likely I'll submit such a patch in the future. > > I'm currently attempting to keep my cleanups to a single error/warning > type so I get as much done as possible per patch while also keeping > the patch easy to review. Is this wrong? No, it's the appropriate thing to do. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
