On Thu, Aug 21, 2014 at 09:06:40AM -0300, Fabio Estevam wrote:
> Hi Mark,
>
> On Thu, Aug 21, 2014 at 6:18 AM, Mark Einon <mark.einon@xxxxxxxxx> wrote:
>
> >
> > Hi Fabio, thanks for the review.
> >
> > It's a space alignment of parameters to go with the previous change, to
> > keep wrapping consistent in the file:
> >
> > - while (i2c_wack) {
> > + while (1) {
> > if (pci_write_config_byte(pdev, LBCIF_CONTROL_REGISTER,
> > - LBCIF_CONTROL_LBCIF_ENABLE))
> > + LBCIF_CONTROL_LBCIF_ENABLE))
> >
> > So what are you saying - are you just commenting, document it, put it
> > in a seperate patch?
>
> Yes, it would be better if this part was part of a separate patch.
Ok, I'll remove the indenting changes and sned them in a future patch.
I'll submit a revised v2 of this one.
Cheers,
Mark
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
