Re: [PATCH 1/4] staging: unisys: remove do{} while(0) in channel.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 18, 2014 at 07:19:53PM +0300, Dan Carpenter wrote:
> On Mon, Aug 18, 2014 at 09:21:43AM -0400, Benjamin Romer wrote:
> >  #define CHANNEL_GUID_MISMATCH(chType, chName, field, expected, actual, fil, \
> >  			      lin, logCtx)				\
> > -	do {								\
> > +	{								\
> >  		pr_err("Channel mismatch on channel=%s(%pUL) field=%s expected=%pUL actual=%pUL @%s:%d\n", \
> >  		       chName, &chType, field,	\
> >  		       &expected, &actual, \
> >  		       fil, lin);					\
> 
> Adjust this line as well.  Remove the ';' and the '\'.
> 
> Same for everything.
> 

Oh wait...  Remove the curly braces as well.  No need for a new block.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux