On 14 August 2014 08:06, Roger Tseng <rogerable@xxxxxxxxxxx> wrote: > On Wed, 2014-08-13 at 17:09 +0200, Ulf Hansson wrote: >> On 11 August 2014 10:32, <rogerable@xxxxxxxxxxx> wrote: >> > From: Roger Tseng <rogerable@xxxxxxxxxxx> >> > >> > Current code erroneously fill the last byte of R2 response with an undefined >> > value. In addition, it is impossible to obtain the real values since the >> > controller actually 'offloads' the last byte(CRC7, end bit) while receiving R2 >> > response. This could cause mmc stack to obtain inconsistent CID from the same >> > card after resume and misidentify it as a different card. >> > >> > Fix by assigning a dummy value 0x01 to the last byte of R2 response. >> > >> > Signed-off-by: Roger Tseng <rogerable@xxxxxxxxxxx> >> >> Thanks! Queued for 3.18. >> >> I guess this should go for stable as well? > Yes. However, since rtsx_usb* is present in 3.16 and later, this patch > will not apply on 3.15.y or older. Should I separately send an adapted > version to stable? I haven't pushed this externally yet. I will drop the patch from my 3.18 branch. Then, let's split the patch into two, one for usb and one for pci - that should simplify patch management. Additionally, you should include a Cc tag with proper hashmark telling which kernel each patch should be included into. Kind regards Uffe _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
