On Tue, Aug 12, 2014 at 09:28:13AM +0900, DaeSeok Youn wrote: > Hi, Dan > > 2014-08-11 19:56 GMT+09:00 Dan Carpenter <dan.carpenter@xxxxxxxxxx>: > > On Sat, Aug 09, 2014 at 02:36:44PM +0900, Daeseok Youn wrote: > >> dgap_major_serial_registered and dgap_major_transparent_print_registered > >> could be checked whether a board is initialized. > >> But it doesn't need to check that variables becasue dgap module > >> isn't calling the dgap_cleanup_tty() without initializing > >> for a board completely. > > > > I don't understand. What about the call to dgap_cleanup_module() in > > dgap_init_module()? > I think the call of dgap_cleanup_tty() > in dgap_cleanup_module() from dgap_init_module() is not reached. > Because dgap_init_module() is called when driver is loaded, at this > point of time, > there are no boards that are initialized.(dgap_numboards is zero) > > And the change log of this is needed to modify for clearing message. Ah. Ok. Thanks for the explanation. Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
