On Aug 11, 2014, at 9:58 PM, Oleg Drokin wrote: > > On Aug 10, 2014, at 12:34 AM, Greg KH wrote: >> Very odd, with this patch applied, I now get a build warning: >> >> drivers/staging/lustre/lnet/lnet/config.c: In function ‘lnet_parse_ip2nets’: >> drivers/staging/lustre/lnet/lnet/config.c:1193:2: warning: ‘ipaddrs’ may be used uninitialized in this function [-Wmaybe-uninitialized] >> lnet_ipaddr_free_enumeration(ipaddrs, nip); >> ^ > > What's even more odd is that the very previous line also uses ipaddrs, yet it does not trigger the warning. > In any case I believe it's a false positive, since the only way it could remain unitialized is if > libcfs_ipif_enumerate returned negative value (stored in nif in this function) and we check for it being more than zero > before getting to that part of code. > > I'll submit a patch assigning ipaddrs to NULL as a workaround shortly. Err, looking at the wrong function there, it's lnet_ipaddr_enumerate that returns negative if ipaddrs was not changed. Anyway still false positive. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
