On Mon, Aug 11, 2014 at 03:15:54PM -0700, Jeremiah Mahler wrote: > A sparse warning is generated about 'ieee80211_debug_init' and > 'ieee80211_debug_exit' not being declared. > > drivers/staging/rtl8192u/ieee80211/ieee80211_module.c:275:12: warning: > symbol 'ieee80211_debug_init' was not declared. Should it be static? > drivers/staging/rtl8192u/ieee80211/ieee80211_module.c:297:13: warning: > symbol 'ieee80211_debug_exit' was not declared. Should it be static? > > These functions are used outside of this file so using static will not > work. Fix the warning by declaring the functions in the header file, > ieee80211.h > > Signed-off-by: Jeremiah Mahler <jmmahler@xxxxxxxxx> > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > Cc: Teodora Baluta <teobaluta@xxxxxxxxx> > Cc: Andrea Merello <andrea.merello@xxxxxxxxx> > Cc: Joel Pelaez Jorge <joelpelaez@xxxxxxxxx> > Cc: Bob Copeland <me@xxxxxxxxxxxxxxx> > Cc: Joe Perches <joe@xxxxxxxxxxx> > Cc: Arnd Bergmann <arnd@xxxxxxxx> > Cc: Himangi Saraogi <himangi774@xxxxxxxxx> > --- > drivers/staging/rtl8192u/ieee80211/ieee80211.h | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211.h b/drivers/staging/rtl8192u/ieee80211/ieee80211.h > index 1040bab..9cbda69 100644 > --- a/drivers/staging/rtl8192u/ieee80211/ieee80211.h > +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211.h > @@ -2485,6 +2485,12 @@ extern int ieee80211_wx_set_freq(struct ieee80211_device *ieee, struct iw_reques > extern int ieee80211_wx_get_freq(struct ieee80211_device *ieee, struct iw_request_info *a, > union iwreq_data *wrqu, char *b); > > +/* ieee80211_module.c */ > +#ifdef CONFIG_IEEE80211_DEBUG > +extern int __init ieee80211_debug_init(void); > +extern void __exit ieee80211_debug_exit(void); > +#endif /* CONFIG_IEEE80211_DEBUG */ > + As it's a header file, why not always have them here, no need for the ifdef. And __init and __exit don't belong in a .h function prototype. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
