Re: [PATCH] staging: dgnc: remove some unused code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Aug 02, 2014 at 08:06:38PM +0900, Seunghun Lee wrote:
> Remove some unused code.
> 
> CC: Lidza Louina <lidza.louina@xxxxxxxxx>
> CC: Mark Hounschell <markh@xxxxxxxxxx>
> Signed-off-by: Seunghun Lee <waydi1@xxxxxxxxx>
> ---
>  drivers/staging/dgnc/dgnc_cls.c    |   72 +---------
>  drivers/staging/dgnc/dgnc_driver.c |   39 +-----
>  drivers/staging/dgnc/dgnc_driver.h |   70 +---------
>  drivers/staging/dgnc/dgnc_mgmt.c   |   23 ---
>  drivers/staging/dgnc/dgnc_neo.c    |  117 ++--------------
>  drivers/staging/dgnc/dgnc_tty.c    |  271 ++++--------------------------------
>  6 files changed, 48 insertions(+), 544 deletions(-)

That's a big patch for such a small description.

Was all of this code really "unused"?  Please only remove one thing at a
time, so we can review it properly.  This should be split up into a
bunch of different patches, each only doing one thing.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux