On Wed, Aug 06, 2014 at 11:18:13PM +0300, Dan Carpenter wrote:
> On Wed, Aug 06, 2014 at 10:43:00PM +0530, Srikrishan Malik wrote:
> > diff --git a/drivers/staging/lustre/lustre/mdc/mdc_locks.c b/drivers/staging/lustre/lustre/mdc/mdc_locks.c
> > index c03d77c9c5b8..09209171b50c 100644
> > --- a/drivers/staging/lustre/lustre/mdc/mdc_locks.c
> > +++ b/drivers/staging/lustre/lustre/mdc/mdc_locks.c
> > @@ -785,12 +785,12 @@ int mdc_enqueue(struct obd_export *exp, struct ldlm_enqueue_info *einfo,
> > __u64 flags, saved_flags = extra_lock_flags;
> > int rc;
> > struct ldlm_res_id res_id;
> > - static const ldlm_policy_data_t lookup_policy =
> > - { .l_inodebits = { MDS_INODELOCK_LOOKUP } };
> > - static const ldlm_policy_data_t update_policy =
> > - { .l_inodebits = { MDS_INODELOCK_UPDATE } };
> > - static const ldlm_policy_data_t layout_policy =
> > - { .l_inodebits = { MDS_INODELOCK_LAYOUT } };
> > + static const ldlm_policy_data_t lookup_policy = {
> > + .l_inodebits = { MDS_INODELOCK_LOOKUP } };
> > + static const ldlm_policy_data_t update_policy = {
> > + .l_inodebits = { MDS_INODELOCK_UPDATE } };
> > + static const ldlm_policy_data_t layout_policy = {
> > + .l_inodebits = { MDS_INODELOCK_LAYOUT } };
> > static const ldlm_policy_data_t getxattr_policy = {
> > .l_inodebits = { MDS_INODELOCK_XATTR } };
> > ldlm_policy_data_t const *policy = &lookup_policy;
>
> That looks silly before and after. Everything is indented in a funny
> way.
Is this better:
static const ldlm_policy_data_t lookup_policy = {
.l_inodebits = { MDS_INODELOCK_LOOKUP }
};
>
> regards,
> dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
