Re: [PATCH] Staging: speakup: Insert blank lines after declarations in speakup_soft.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 06, 2014 at 06:03:42PM +1000, Artemiy Volkov wrote:
> This patch fixes the checkpatch.pl 'Missing a blank line after declarations' warning in speakup_soft.c.
> 
> Signed-off-by: Artemiy Volkov <artemiyv@xxxxxxx>
> ---
>  drivers/staging/speakup/speakup_soft.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/staging/speakup/speakup_soft.c b/drivers/staging/speakup/speakup_soft.c
> index 9ed7265..b613a08 100644
> --- a/drivers/staging/speakup/speakup_soft.c
> +++ b/drivers/staging/speakup/speakup_soft.c
> @@ -192,6 +192,7 @@ static int softsynth_open(struct inode *inode, struct file *fp)
>  static int softsynth_close(struct inode *inode, struct file *fp)
>  {
>  	unsigned long flags;
> +
>  	spin_lock_irqsave(&speakup_info.spinlock, flags);
>  	synth_soft.alive = 0;
>  	init_pos = 0;
> @@ -282,6 +283,7 @@ static unsigned int softsynth_poll(struct file *fp,
>  		struct poll_table_struct *wait)
>  {
>  	unsigned long flags;
> +
>  	int ret = 0;
>  	poll_wait(fp, &speakup_event, wait);

That line shouldn't be there, right?  It should be one line lower...

Can you fix that up?

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux