Re: [PATCH 05/12] staging: lustre: Add missing spaces around operators and braces.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2014-08-06 at 23:13 +0300, Dan Carpenter wrote:
> On Wed, Aug 06, 2014 at 10:42:55PM +0530, Srikrishan Malik wrote:
> > diff --git a/drivers/staging/lustre/lustre/mdc/mdc_reint.c b/drivers/staging/lustre/lustre/mdc/mdc_reint.c
[]
> > @@ -71,7 +71,7 @@ int mdc_resource_get_unused(struct obd_export *exp, const struct lu_fid *fid,
> >  			    __u64 bits)
> >  {
> >  	struct ldlm_namespace *ns = exp->exp_obd->obd_namespace;
> > -	ldlm_policy_data_t policy = {{0}};
> > +	ldlm_policy_data_t policy = {{0} };
> 
> That's odd.  Since when is a space required here?  Anyway, put one at
> the start too if you're goind to do that.  Or you could do it like:
> 
> 	ldlm_policy_data_t policy = {};
> 
> ?

It comes from a pretty old bit of checkpatch:

de7d4f0e (Andy Whitcroft 2007-07-15 23:37:22 -0700 3706) # closing brace should have a space following it when it has anything
de7d4f0e (Andy Whitcroft 2007-07-15 23:37:22 -0700 3707) # on the line
de7d4f0e (Andy Whitcroft 2007-07-15 23:37:22 -0700 3708)                if ($line =~ /}(?!(?:,|;|\)))\S/) {

Maybe it should have an } added to the test like:

if ($line =~ /}(?!(?:,|;|\)|}))\S/) {


_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux