Re: [PATCH 02/12] staging: unisys: remove U32 type

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jul 31, 2014 at 12:00:50PM -0400, Benjamin Romer wrote:
> @@ -121,7 +120,7 @@ typedef U64 GUEST_PHYSICAL_ADDRESS;
>  		       fil, lin);					\
>  	} while (0)
>  
> -#define CHANNEL_U32_MISMATCH(chType, chName, field, expected, actual, fil, \
> +#define CHANNEL_u32_MISMATCH(chType, chName, field, expected, actual, fil, \
>  			     lin, logCtx)				\
>  	do {								\
>  		syslog(LOG_USER | LOG_ERR,				\

The caller isn't updated so this breaks the build.  You fix it in the
next patch but breaking the build is not allowed.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux