On Wed, 2014-08-06 at 11:18 +0300, Dan Carpenter wrote: > On Tue, Aug 05, 2014 at 02:57:55PM -0400, Benjamin Romer wrote: > > The CHANNEL_*_MISMATCH error message macros should not be inside of do blocks. > > > > Why not? We do that so they can be called like a function. These seem > to not be called at all. Just delete them (in a later patch). I ran checkpatch.pl against the channel.h file and it complains about the do blocks in the macros there. It also complains about do blocks in iochannel.h. It's only a warning though. I'm all in favor of deleting them - they get used in ULTRA_check_channel_client() in the same file, and only there. I'll just remove the macros and put the equivalent code in where they were used. -- Ben Romer | Software Engineer | Virtual Systems Development Unisys Corporation | 2476 Swedesford Rd | Malvern, PA 19355 | 610-648-7140 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
