This series of patches cleans up a bit the dgnc code. The focus is mostly put on the dgnc_driver.c file however the sparse warning from the other file has been fixed too. There is no functional changes, only the sparse warnings have been fixed, some of the checkpath issues have been fixed too (except on line over 80 chars warnings). Because the TODO file for this driver was not valid the bullet list in it has been updated with the current status. The update is based on what I have found in the driver devel mailing list archives for this driver. Konrad Zapalowicz (7): staging: dgnc: Fix externs should be avoided in the .c files staging: dgnc: Fix no spaces before tabs checkpath warning staging: dgnc: Fix frame size is larger than 1024B staging: dgnc: Remove unnecessary functions from dgnc_driver.c staging: dgnc: Move utility functions out of dgnc_driver.c staging: dgnc: Siplify the dgnc_start function staging: dgnc: Update the TODO file drivers/staging/dgnc/Makefile | 3 +- drivers/staging/dgnc/TODO | 5 - drivers/staging/dgnc/dgnc_driver.c | 287 ++++++++++++------------------------- drivers/staging/dgnc/dgnc_driver.h | 10 -- drivers/staging/dgnc/dgnc_tty.c | 17 ++- drivers/staging/dgnc/dgnc_utils.c | 70 +++++++++ drivers/staging/dgnc/dgnc_utils.h | 7 + 7 files changed, 182 insertions(+), 217 deletions(-) create mode 100644 drivers/staging/dgnc/dgnc_utils.c create mode 100644 drivers/staging/dgnc/dgnc_utils.h -- 1.8.1.2 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel