On Tue, 2014-08-05 at 00:45 +0200, Adrian Remonda wrote:
> This is a patch to the hal/rtl8188eu_recv.c file that fixes up a "line
> over 80 characters" warning found by the checkpatch.pl tool.
[]
> diff --git a/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c b/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c
> index f25c87c..8be4819 100644
> --- a/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c
> +++ b/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c
> @@ -41,15 +41,19 @@ int rtl8188eu_init_recv_priv(struct adapter *padapter)
> /* init recv_buf */
> _rtw_init_queue(&precvpriv->free_recv_buf_queue);
>
> - precvpriv->pallocated_recv_buf = kzalloc(NR_RECVBUFF * sizeof(struct recv_buf) + 4, GFP_KERNEL);
> + precvpriv->pallocated_recv_buf =
> + kzalloc(NR_RECVBUFF * sizeof(struct recv_buf) + 4, GFP_KERNEL);
> if (precvpriv->pallocated_recv_buf == NULL) {
> res = _FAIL;
> - RT_TRACE(_module_rtl871x_recv_c_, _drv_err_, ("alloc recv_buf fail!\n"));
> + RT_TRACE(_module_rtl871x_recv_c_, _drv_err_,
> + ("alloc recv_buf fail!\n"));
> goto exit;
> }
> - memset(precvpriv->pallocated_recv_buf, 0, NR_RECVBUFF * sizeof(struct recv_buf) + 4);
> + memset(precvpriv->pallocated_recv_buf, 0,
> + NR_RECVBUFF * sizeof(struct recv_buf) + 4);
>
> - precvpriv->precv_buf = (u8 *)N_BYTE_ALIGMENT((size_t)(precvpriv->pallocated_recv_buf), 4);
> + precvpriv->precv_buf = (u8 *)N_BYTE_ALIGMENT((size_t)
> + (precvpriv->pallocated_recv_buf), 4);
Several bits of this are not nice.
the +4 seems senseless.
zalloc followed by a memset(,0,) is senseless.
N_BYTE_ALIGNMENT seems senseless as alloc is
suitable for any alignmet.
btw: The merge window is open, please be patient
with any staging patch during the merge window.
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
