On Monday, August 04, 2014 6:05 AM, Ian Abbott wrote: > On 2014-08-01 22:18, H Hartley Sweeten wrote: >> This driver currently duplicates the functionality of the 8255 module. >> The only difference is in how the i/o access is handled. >> >> Provide a private (*io) callback for the 8255 module to handle the >> differences. We can then use that module and initialize the subdevice >> with subdev_8255_init(). >> >> Update the Kconfig to select the COMEDI_8255 module. >> >> Signed-off-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx> >> Cc: Ian Abbott <abbotti@xxxxxxxxx> >> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > > I have plans to support some of the enhancements in the PCIe cards, > which would mean I can't use the 8255 module. That's one of the reasons > I implemented the 8255 functionality directly in the driver (there's not > very much anyway). The other was it would have been a bit of a pain as > the comedi 'dev' parameter wasn't passed through. Well, the comedi 'dev' parameter will be passed through after this series is applied. Can the additional functionality be handled with just a custom (*insn_config)? The pcm2734 does this in order to configure the external buffers that are tied to the 8255 device. > So I'd prefer to drop this patch so I don't have to undo it later. Not a problem. I'll drop this one. Regards, Hartley _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
