On Sun, Aug 03, 2014 at 04:54:21PM +0200, Martin Kepplinger wrote: > @@ -447,6 +457,13 @@ static uint8_t as102_fe_get_code_rate(fe_code_rate_t arg) > static void as102_fe_copy_tune_parameters(struct as10x_tune_args *tune_args, > struct dtv_frontend_properties *params) > { > + struct dvb_frontend *fe; > + struct as102_dev_t *dev; > + > + fe = container_of(params, struct dvb_frontend, dtv_property_cache); > + dev = (struct as102_dev_t *) fe->tuner_priv; > + if (dev == NULL) > + dev_err(&dev->bus_adap.usb_dev->dev, "No device found\n"); NULL dereference in printing error message. I think smatch or coccinelle would detect this although I haven't tried either. This is the typical bug for this kind of patch. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel