Delete commontypes.h, and replace all of the places that #included it with correct #includes for the types used in that file. Signed-off-by: Benjamin Romer <benjamin.romer@xxxxxxxxxx> --- .../unisys/common-spar/include/channels/channel.h | 4 +-- .../include/channels/controlframework.h | 2 +- .../include/channels/controlvmchannel.h | 1 - .../common-spar/include/channels/diagchannel.h | 2 +- .../common-spar/include/channels/iochannel.h | 1 - .../common-spar/include/channels/vbuschannel.h | 1 - .../unisys/common-spar/include/vbusdeviceinfo.h | 2 +- drivers/staging/unisys/include/commontypes.h | 29 ---------------------- drivers/staging/unisys/uislib/uislib.c | 3 ++- drivers/staging/unisys/uislib/uisutils.c | 3 ++- drivers/staging/unisys/virtpci/virtpci.c | 4 ++- drivers/staging/unisys/visorchannel/visorchannel.h | 1 - 12 files changed, 12 insertions(+), 41 deletions(-) delete mode 100644 drivers/staging/unisys/include/commontypes.h diff --git a/drivers/staging/unisys/common-spar/include/channels/channel.h b/drivers/staging/unisys/common-spar/include/channels/channel.h index d861a3f..2004cfe 100644 --- a/drivers/staging/unisys/common-spar/include/channels/channel.h +++ b/drivers/staging/unisys/common-spar/include/channels/channel.h @@ -16,6 +16,8 @@ #ifndef __CHANNEL_H__ #define __CHANNEL_H__ +#include <linux/types.h> +#include <linux/io.h> #include <linux/uuid.h> /* @@ -30,8 +32,6 @@ */ #define __SUPERVISOR_CHANNEL_H__ -#include "commontypes.h" - #define SIGNATURE_16(A, B) ((A) | (B<<8)) #define SIGNATURE_32(A, B, C, D) \ (SIGNATURE_16(A, B) | (SIGNATURE_16(C, D) << 16)) diff --git a/drivers/staging/unisys/common-spar/include/channels/controlframework.h b/drivers/staging/unisys/common-spar/include/channels/controlframework.h index b0a49e0..fd4726e 100644 --- a/drivers/staging/unisys/common-spar/include/channels/controlframework.h +++ b/drivers/staging/unisys/common-spar/include/channels/controlframework.h @@ -25,7 +25,7 @@ #ifndef _CONTROL_FRAMEWORK_H_ #define _CONTROL_FRAMEWORK_H_ -#include "commontypes.h" +#include <linux/types.h> #include "channel.h" #define ULTRA_MEMORY_COUNT_Ki 1024 diff --git a/drivers/staging/unisys/common-spar/include/channels/controlvmchannel.h b/drivers/staging/unisys/common-spar/include/channels/controlvmchannel.h index 7cdce23..d08c198 100644 --- a/drivers/staging/unisys/common-spar/include/channels/controlvmchannel.h +++ b/drivers/staging/unisys/common-spar/include/channels/controlvmchannel.h @@ -17,7 +17,6 @@ #define __CONTROLVMCHANNEL_H__ #include <linux/uuid.h> -#include "commontypes.h" #include "channel.h" #include "controlframework.h" diff --git a/drivers/staging/unisys/common-spar/include/channels/diagchannel.h b/drivers/staging/unisys/common-spar/include/channels/diagchannel.h index c01649a..9912e51 100644 --- a/drivers/staging/unisys/common-spar/include/channels/diagchannel.h +++ b/drivers/staging/unisys/common-spar/include/channels/diagchannel.h @@ -33,7 +33,7 @@ #ifndef _DIAG_CHANNEL_H_ #define _DIAG_CHANNEL_H_ -#include "commontypes.h" +#include <linux/uuid.h> #include "channel.h" /* {EEA7A573-DB82-447c-8716-EFBEAAAE4858} */ diff --git a/drivers/staging/unisys/common-spar/include/channels/iochannel.h b/drivers/staging/unisys/common-spar/include/channels/iochannel.h index 1ab8028..ed66c27 100644 --- a/drivers/staging/unisys/common-spar/include/channels/iochannel.h +++ b/drivers/staging/unisys/common-spar/include/channels/iochannel.h @@ -31,7 +31,6 @@ #include <linux/uuid.h> -#include "commontypes.h" #include "vmcallinterface.h" #define _ULTRA_CONTROLVM_CHANNEL_INLINE_ diff --git a/drivers/staging/unisys/common-spar/include/channels/vbuschannel.h b/drivers/staging/unisys/common-spar/include/channels/vbuschannel.h index 8facb51..1231c45 100644 --- a/drivers/staging/unisys/common-spar/include/channels/vbuschannel.h +++ b/drivers/staging/unisys/common-spar/include/channels/vbuschannel.h @@ -24,7 +24,6 @@ * the client devices and client drivers for the server end to see. */ #include <linux/uuid.h> -#include "commontypes.h" #include "vbusdeviceinfo.h" #include "channel.h" diff --git a/drivers/staging/unisys/common-spar/include/vbusdeviceinfo.h b/drivers/staging/unisys/common-spar/include/vbusdeviceinfo.h index 5e0d98c..54593c1 100644 --- a/drivers/staging/unisys/common-spar/include/vbusdeviceinfo.h +++ b/drivers/staging/unisys/common-spar/include/vbusdeviceinfo.h @@ -16,7 +16,7 @@ #ifndef __VBUSDEVICEINFO_H__ #define __VBUSDEVICEINFO_H__ -#include "commontypes.h" +#include <linux/types.h> #pragma pack(push, 1) /* both GCC and VC now allow this pragma */ diff --git a/drivers/staging/unisys/include/commontypes.h b/drivers/staging/unisys/include/commontypes.h deleted file mode 100644 index eafd83b..0000000 --- a/drivers/staging/unisys/include/commontypes.h +++ /dev/null @@ -1,29 +0,0 @@ -/* Copyright (C) 2010 - 2013 UNISYS CORPORATION - * All rights reserved. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or (at - * your option) any later version. - * - * This program is distributed in the hope that it will be useful, but - * WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE, GOOD TITLE or - * NON INFRINGEMENT. See the GNU General Public License for more - * details. - */ - -#ifndef _COMMONTYPES_H_ -#define _COMMONTYPES_H_ - -/* define the following to prevent include nesting in kernel header files of - * similar abbreviated content */ -#define _SUPERVISOR_COMMONTYPES_H_ - -#include <linux/types.h> -#include <linux/version.h> -#include <linux/io.h> -#include <linux/uuid.h> - -#endif - diff --git a/drivers/staging/unisys/uislib/uislib.c b/drivers/staging/unisys/uislib/uislib.c index 63c91cd..a3a96ad 100644 --- a/drivers/staging/unisys/uislib/uislib.c +++ b/drivers/staging/unisys/uislib/uislib.c @@ -25,7 +25,8 @@ #include <linux/module.h> #include <linux/debugfs.h> -#include "commontypes.h" +#include <linux/types.h> +#include <linux/uuid.h> #include <linux/version.h> #include "uniklog.h" diff --git a/drivers/staging/unisys/uislib/uisutils.c b/drivers/staging/unisys/uislib/uisutils.c index ee26e00..3a59965 100644 --- a/drivers/staging/unisys/uislib/uisutils.c +++ b/drivers/staging/unisys/uislib/uisutils.c @@ -17,7 +17,8 @@ #include <linux/string.h> #include <linux/slab.h> -#include <commontypes.h> +#include <linux/types.h> +#include <linux/uuid.h> #include <linux/spinlock.h> #include <linux/list.h> #include "uniklog.h" diff --git a/drivers/staging/unisys/virtpci/virtpci.c b/drivers/staging/unisys/virtpci/virtpci.c index d9443a9..261a52f 100644 --- a/drivers/staging/unisys/virtpci/virtpci.c +++ b/drivers/staging/unisys/virtpci/virtpci.c @@ -24,9 +24,11 @@ #include "uniklog.h" #include "diagnostics/appos_subsystems.h" #include "uisutils.h" -#include "commontypes.h" #include "vbuschannel.h" #include "vbushelper.h" +#include <linux/types.h> +#include <linux/io.h> +#include <linux/uuid.h> #include <linux/module.h> #include <linux/init.h> #include <linux/pci.h> diff --git a/drivers/staging/unisys/visorchannel/visorchannel.h b/drivers/staging/unisys/visorchannel/visorchannel.h index aa17a84..9a4d7b6 100644 --- a/drivers/staging/unisys/visorchannel/visorchannel.h +++ b/drivers/staging/unisys/visorchannel/visorchannel.h @@ -20,7 +20,6 @@ #include <linux/uuid.h> -#include "commontypes.h" #include "memregion.h" #include "channel.h" #ifndef HOSTADDRESS -- 1.9.1 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel