Re: [PATCH 2/2] staging: rlt8192u: conditional compilation in r8192U_core.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 01, 2014 at 12:59:43AM -0700, Greg KH wrote:
> >  /* this is only for debug */
> > +#ifdef DEBUG_EPROM
> 
> how can this ever be set?  If no one sets it, just remove the code
> entirely please.

I guess it's supposed to be set manually in the code (there's a large
list around l.60).

> > +#ifndef USE_ONE_PIPE
> 
> Same here, if the option can never be selected, just delete the code.
> 
> > +#ifdef USB_RX_AGGREGATION_SUPPORT
> 
> Same here.

These two are set in the Makefile, but not configurable from the
outside.

I'll remove all of these, and possibly other options in the same case.

Antoine
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux