The "amplc_pci224" driver retains a "legacy" attach mechanism via the
`COMEDI_DEVCONFIG` ioctl and the comedi driver "attach" hook, but
usually attaches PCI devices automatically via the comedi driver's
"auto_attach" hook. The legacy mechanism is only retained so that
options can be passed via the ioctl to indicate how some hardware
jumpers are set on the boards, which is used to set up the range tables.
That's no use if the PCI device is attached automatically as the range
tables will be set up according to the factory default jumper positions.
Change the range tables to include all possible ranges, regardless of
jumper positions. Then there is no need to have options to control
setting up the range tables and the "legacy" attach mechanism can be
removed.
Also, tidy the code up a bit.
01) staging: comedi: amplc_pci224: reformat some comments
02) staging: comedi: amplc_pci224: fix checkpatch line over 80
characters
03) staging: comedi: amplc_pci224: blank lines aren't necessary before a
close brace '}'
04) staging: comedi: amplc_pci224: multiple assignments should be
avoided
05) staging: comedi: amplc_pci224: fix spinlock_t definition without
comment
06) staging: comedi: amplc_pci224: add whitespace to pci224_boards[]
07) staging: comedi: amplc_pci224: set a more descriptive
MODULE_DESCRIPTION()
08) staging: comedi: amplc_pci224: omit '!= 0' from logical expressions
09) staging: comedi: amplc_pci224: remove some unnecessary parentheses
10) staging: comedi: amplc_pci224: reduce leading whitespace in a few
places
11) staging: comedi: amplc_pci224: no need for '&function'
12) staging: comedi: amplc_pci224: remove options to select output
ranges
13) staging: comedi: amplc_pci224: remove "legacy" attach mechanism
14) staging: comedi: amplc_pci224: no need to manipulate PCI ref count
15) staging: comedi: amplc_pci224: put board indices in PCI driver_data
16) staging: comedi: amplc_pci224: remove PCI_DEVICE_ID_... macros
17) staging: comedi: amplc_pci224: absorb pci224_attach_common()
18) staging: comedi: amplc_pci224: no need to comedi_set_hw_dev() here
drivers/staging/comedi/drivers/amplc_pci224.c | 661 ++++++++++----------------
1 file changed, 254 insertions(+), 407 deletions(-)
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
