Re: [PATCH 02/19] staging: comedi: ni_tio: tidy up Gi_Counting_Mode_Reg_Bits

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2014-07-29 17:04, Hartley Sweeten wrote:
On Tuesday, July 29, 2014 2:22 AM, Ian Abbott wrote:
I see the original function was inline as well, so maybe that should be
a separate patch to remove the inlines.

As you noted, the original was inline. I plan on removing these.

I renamed the function ALL CAPS so it follows the defines and macros used
for the other GI_* bit defines. These inline functions should also be macros
but they are a bit messy due to the 'variant' testing.

I'm still trying to figure out a clean way of making them macros.

Well CodingStyle says, "Generally, inline functions are preferable to macros resembling functions."

--
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@xxxxxxxxx>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux