Hi, these are my patches for the drivers/staging/bcm/Qos.c file. Please review them. If you want, I can squash the "Line length / Whitespace cleanup" patches into one big patch, but I guess it is better this way, also for reviewing them. Please note, as always: As I do not have the appropriate hardware, I'm not able to test these patches. I compiled them at least. Kind regards, Matthias Beyer Matthias Beyer (27): Staging: bcm: Qos.c: Replaced member accessing with variable in PruneQueue() Staging: bcm: Qos.c: Replaced member accessing with variable in MatchDestIpAddress() Staging: bcm: Qos.c: Replaced do-while(0) jumps with goto and label, removes one level of indentation Staging: bcm: Qos.c: Replaced member accessing with variable in PruneQueue() Staging: bcm: Qos.c: Replaced member accessing by variable in flush_all_queues() Staging: bcm: Qos.c: Replaced do-while(0) breaks with continue Staging: bcm: Qos.c: Replaced if-else return with ternary operator Staging: bcm: Qos.c: Line length / Whitespace cleanup in MatchSrcIpAddress() Staging: bcm: Qos.c: Line length / Whitespace cleanup in MatchDestIpAddress() Staging: bcm: Qos.c: Line length / Whitespace cleanup in MatchTos() Staging: bcm: Qos.c: Line length / Whitespace cleanup in MatchProtocol() Staging: bcm: Qos.c: Line length / Whitespace cleanup in MatchSrcPort() Staging: bcm: Qos.c: Line length / Whitespace cleanup in MatchDestPort() Staging: bcm: Qos.c: Line length / Whitespace cleanup in IpVersion4() Staging: bcm: Qos.c: Line length / Whitespace cleanup in PruneQueue() Staging: bcm: Qos.c: Line length / Whitespace cleanup in flush_all_queues() Staging: bcm: Qos.c: Line length / Whitespace cleanup in ClassifyPacket() Staging: bcm: Qos.c: Line length / Whitespace cleanup in EthCSMatchSrcMACAdress() Staging: bcm: Qos.c: Line length / Whitespace cleanup in EthCSMatchDestMACAdress() Staging: bcm: Qos.c: Line length / Whitespace cleanup in EthCSMatchEThTypeSAP() Staging: bcm: Qos.c: Line length / Whitespace cleanup in EthCSMatchVLANRules() Staging: bcm: Qos.c: Line length / Whitespace cleanup in EThCSClassifyPkt() Staging: bcm: Qos.c: Line length / Whitespace cleanup in EThCSGetPktInfo() Staging: bcm: Qos.c: checkpatch.pl fix: Added blank lines after declarations Staging: bcm: Qos.c: checkpatch.pl fix: Transformed C99-style comments Staging: bcm: Qos.c: checkpatch.pl fix: Removed parentheses from return statement Staging: bcm: Qos.c: checkpatch.pl fix: Indentation of case-statements fixed drivers/staging/bcm/Qos.c | 902 +++++++++++++++++++++++++++++++++------------- 1 file changed, 652 insertions(+), 250 deletions(-) -- 2.0.3 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel