Re: [PATCH 00/19] staging: comedi: ni_tio: cleanup CamelCase issues

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2014-07-28 18:26, H Hartley Sweeten wrote:
Fix the CamelCase issues by replacing the enums used for the register
bits with simple defines/macros and renaming the symbols.

Remove some unnecessary BUG() checks and tidy up some of the functions
in ni_tiocmd.

H Hartley Sweeten (19):
   staging: comedi: ni_tio: tidy up ni_tio_read_sw_save_reg()
   staging: comedi: ni_tio: tidy up Gi_Counting_Mode_Reg_Bits
   staging: comedi: ni_tio: tidy up Gi_Command_Reg_Bits
   staging: comedi: ni_tio: tidy up Gi_Auto_Increment_Reg_Bits
   staging: comedi: ni_tio: tidy up Gi_Input_Select_Bits
   staging: comedi: ni_tio: tidy up Gi_Mode_Bits
   staging: comedi: ni_tio: tidy up Gi_Second_Gate_Bits
   staging: comedi: ni_tio: tidy up Gxx_Status_Bits
   staging: comedi: ni_tio: tidy up Gi_Reset_Bit
   staging: comedi: ni_tio: tidy up Gxx_Joint_Status2_Bits
   staging: comedi: ni_tio: tidy up Gi_DMA_Config_Reg_Bits
   staging: comedi: ni_tio: tidy up Gi_DMA_Status_Reg_Bits
   staging: comedi: ni_tio: tidy up Gxx_Interrupt_Acknowledge_Bits
   staging: comedi: ni_tio: tidy up Gi_Status_Bits
   staging: comedi: ni_tio: tidy up G{02,12}_Interrupt_Enable_Bits
   staging: comedi: ni_tiocmd: tidy up ni_tio_configure_dma()
   staging: comedi: ni_tiocmd: tidy up ni_tio_input_inttrig()
   staging: comedi: ni_tiocmd: tidy up ni_tio_input_cmd()
   staging: comedi: ni_tiocmd: introduce ni_tio_acknowledge()

  drivers/staging/comedi/drivers/ni_660x.c         |   2 +-
  drivers/staging/comedi/drivers/ni_mio_common.c   |   2 +-
  drivers/staging/comedi/drivers/ni_stc.h          |   8 -
  drivers/staging/comedi/drivers/ni_tio.c          | 298 ++++++++----------
  drivers/staging/comedi/drivers/ni_tio.h          |   4 +-
  drivers/staging/comedi/drivers/ni_tio_internal.h | 385 +++++++----------------
  drivers/staging/comedi/drivers/ni_tiocmd.c       | 139 ++++----
  7 files changed, 313 insertions(+), 525 deletions(-)


Reviewed-by: Ian Abbott <abbotti@xxxxxxxxx>

--
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@xxxxxxxxx>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux