On Mon, 2014-07-28 at 21:09 -0300, Murilo Opsfelder Araujo wrote:
> This patch makes checkpatch.pl script happier by fixing all warnings
> related to else statement after break or return.
[]
> diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c
[]
> @@ -561,10 +561,10 @@ static int bcm_char_ioctl_gpio_set_request(void __user *argp,
> BCM_DEBUG_PRINT(Adapter, DBG_TYPE_OTHERS, OSAL_DBG, DBG_LVL_ALL,
> "GPIO_MODE_REGISTER read failed");
> return Status;
> - } else {
> - Status = STATUS_SUCCESS;
> }
>
> + Status = STATUS_SUCCESS;
This set of Status is unnecessary
> /* Set the gpio mode register to output */
> *(UINT *)ucResetValue |= (1<<uiBit);
> Status = wrmaltWithLock(Adapter, GPIO_MODE_REGISTER,
as it's immediately overwritten.
> @@ -669,10 +669,10 @@ static int bcm_char_ioctl_gpio_status_request(void __user *argp,
> Status = bytes;
> BCM_DEBUG_PRINT(Adapter, DBG_TYPE_PRINTK, 0, 0,
> "RDM Failed\n");
> - return Status;
> } else {
> Status = STATUS_SUCCESS;
> }
> +
> return Status;
return STATUS_SUCCESS;
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
