On Sunday, July 27, 2014 11:45 AM, Greg Kroah-Hartman wrote: > On Fri, Jul 25, 2014 at 06:23:10PM +0000, Hartley Sweeten wrote: >> On Friday, July 25, 2014 10:07 AM, Ian Abbott wrote: >>> `dio200_detach()` in "amplc_dio200.c" calls >>> `amplc_dio200_common_detach()` in "amplc_dio200_common.c", followed by >>> `comedi_legacy_detach()` in "../drivers.c". Both of those functions >>> call `free_irq()` if `dev->irq` is non-zero. The second call produces a >>> warning message because the handler has already been freed. Prevent >>> that by setting `dev->irq = 0` in `amplc_dio200_common_detach()`. >>> >>> Signed-off-by: Ian Abbott <abbotti@xxxxxxxxx> >>> >> I have already gave a Reviewed-by signoff for this series. >> >> After looking over the code I think a cleaner solution would be to: >> >> 1) Use comedi_legacy_detach() directly for the (*detach) in the >> legacy ISA driver. >> 2) Move the code from amplc_dio200_common_detach() into the >> (*detach) function for the PCI driver. >> 3) Remove the exported function amplc_dio200_common_detach(). > > So should I not apply these patches? Greg, Yes, please apply this series from Ian. It does fix a bug with the duplicate free_irq(). The comments I gave can be addressed in a later patch. Sorry for the confusion. Hartley _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
