On Sun, 2014-07-27 at 19:08 +0200, Nicolas Thery wrote:
> This patch fixes the following errors and warnings:
[]
> diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_proc.c b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_proc.c
[]
> @@ -23,34 +23,38 @@
[]
> -#define seq_putx(m, message, size, var) \
> +#define seq_putx(m, message, size, var) do { \
> seq_printf(m, message); \
> for (i = 0; i < (size - 1); i++) { \
> seq_printf(m, "%02x:", var[i]); \
> } \
> - seq_printf(m, "%02x\n", var[i])
> + seq_printf(m, "%02x\n", var[i]); \
> +} while (0)
Ideally, these wouldn't depend on an external
i variable.
Maybe something like:
#define seq_putx(m, message, size, var) \
do { \
int _i; \
seq_printf(m, message); \
for (_i = 0; _i < (size - 1); _i++) \
seq_printf(m, "%02x:", var[_i]); \
seq_printf(m, "%02x\n", var[_i]); \
} while (0)
> -#define seq_putd(m, message, size, var) \
> +#define seq_putd(m, message, size, var) do { \
> seq_printf(m, message); \
> for (i = 0; i < (size - 1); i++) { \
> seq_printf(m, "%d.", var[i]); \
> } \
> - seq_printf(m, "%d\n", var[i])
> + seq_printf(m, "%d\n", var[i]); \
> +} while (0)
Maybe later change these to use the recently introduced
seq_hex_dump: https://lkml.org/lkml/2014/7/11/269
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
