On Fri, Jul 25, 2014 at 10:08:06PM +0400, Denis Kirjanov wrote: > On 7/25/14, Benjamin Romer <benjamin.romer@xxxxxxxxxx> wrote: > > This patch cleans up the style, error handling, and string handling in the > > sysfs > > functions recently added to visorchipset: > > Split your changes and send one logical change per patch You can go mad with following rules. In staging we're trying to apply as many patches as we can so we're less picky. I think this patch is ok. In theory you could split this patch up with: 1) Fix the bug. 2) Other cleanups. But in reality the patch doesn't need to be backported so we can allow it. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel