On Fri, 2014-07-25 at 14:05 +0300, Dan Carpenter wrote: > visorchannel_write() returns either 0 or -EFAULT so this condition is > never true. This bug occurs in several places. Thank you for catching my mistake. I'll fix this and change visorchannel_write() to return -EIO as you suggested. > Look, Ma, no indenting! Also -EIO is wrong-ish. visorchannel_write() > should probably return -EIO instead of -EFAULT. Do it like this: Will do. I'll also check for additional places where we can simplify the code like that. Thank you for the help!! :) -- Ben Romer | Software Engineer | Virtual Systems Development Unisys Corporation | 2476 Swedesford Rd | Malvern, PA 19355 | 610-648-7140 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
