On 2014-07-24 18:14, H Hartley Sweeten wrote:
Start cleaning up this driver by:
1) fix all the checkpatch.pl warnings
WARNING: line over 80 characters
WARNING: Unnecessary space before function pointer arguments
WARNING: Prefer [foo]_err to printk(KERN_ERR ...
2) remove a bunch of unreachable BUG() code
3) tidy up some of the CamelCase issues
4) remove need for all the forward declarations
5) general cleanup
H Hartley Sweeten (40):
staging: comedi: ni_tio: fix ni_tio_insn_read()
staging: comedi: ni_tio: fix > 80 char comments
staging: comedi: ni_tio: tidy up some function declarations
staging: comedi: ni_tio: remove unnecessary ni_gpct_variant BUG() cases
staging: comedi: ni_tio: tidy up ni_660x_set_second_gate()
staging: comedi: ni_tio: tidy up ni_m_series_set_first_gate()
staging: comedi: ni_tio: tidy up ni_660x_set_first_gate()
staging: comedi: ni_tio: convert NI_M_Series_RTSI_Clock() to a macro
staging: comedi: ni_tio: convert NI_M_Series_PFI_Clock() to a macro
staging: comedi: ni_tio: convert NI_660x_Gate_Pin_Gate_Select() to a macro
staging: comedi: ni_tio: convert NI_660x_RTSI_Gate_Select() to a macro
staging: comedi: ni_tio: convert NI_M_Series_RTSI_Gate_Select() to a macro
staging: comedi: ni_tio: convert NI_M_Series_PFI_Gate_Select() to a macro
staging: comedi: ni_tio: convert NI_660x_Source_Pin_Clock() to a macro
staging: comedi: ni_tio: convert NI_660x_RTSI_Clock() to a macro
staging: comedi: ni_tio: convert NI_660x_RTSI_Second_Gate_Select() to a macro
staging: comedi: ni_tio: convert NI_660x_Up_Down_Pin_Second_Gate_Select() to a macro
staging: comedi: ni_tio: convert global static const variables to defines
staging: comedi: ni_tio: remove counter_status_mask
staging: comedi: ni_tio: tidy up enum ni_660x_second_gate_select
staging: comedi: ni_tio: tidy up enum ni_m_series_gate_select
staging: comedi: ni_tio: tidy up enum ni_660x_gate_select
staging: comedi: ni_tio: tidy up enum ni_m_series_clock_source
staging: comedi: ni_tio: tidy up enum ni_660x_clock_source
staging: comedi: ni_tio: move defines to head of file
staging: comedi: ni_tio: tidy up ni_gpct_device_{construct,destroy)()
staging: comedi: ni_tio: tidy up ni_tio_init_counter()
staging: comedi: ni_tio: rename ni_tio_second_gate_registers_present()
staging: comedi: ni_tio: tidy up ni_m_series_source_select_bits()
staging: comedi: ni_tio: tidy up ni_660x_source_select_bits()
staging: comedi: ni_tio: tidy up ni_tio_set_sync_mode()
staging: comedi: ni_tio: absorb ni_tio_counter_status()
staging: comedi: ni_tio: tidy up ni_tio_get_gate_src() and helpers
staging: comedi: ni_tio: tidy up ni_tio_set_other_src()
staging: comedi: ni_tio: tidy up ni_tio_set_gate_src() and helpers
staging: comedi: ni_tio: absorb ni_tio_set_first_gate_modifiers()
staging: comedi: ni_tio: tidy up ni_tio_get_clock_src()
staging: comedi: ni_tio: tidy up ni_tio_set_clock_src() and helpers
staging: comedi: ni_tio: remove forward declarations
staging: comedi: ni_tio: convert printk to pr_err
drivers/staging/comedi/drivers/ni_tio.c | 1609 ++++++++++++++-----------------
1 file changed, 736 insertions(+), 873 deletions(-)
Reviewed-by: Ian Abbott <abbotti@xxxxxxxxx>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
